This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Add more simple types #1843
Merged
Add more simple types #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
approved these changes
Dec 12, 2016
adidahiya
suggested changes
Dec 12, 2016
|
I wouldn't mind waiting for version 5 to do this. |
|
What about I just want to add this to the discussion. I don't have an opinion wether they should be considered simple types or not. |
|
yeah it's a subjective call about what is considered "simple" here. IMO the examples you just proposed are a little confusing to read (partially because literals in type positions are a more recent addition to the language), so I would prefer writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
Consider the
undefinedandnevertypes to be simple types. This allows writingundefined[]ornever[].The second commit changes tests to prove that I changed something. Could be removed if you think it's ugly.
[rule-update]
array-typenow considerundefinedandneveras simple types, allowingundefined[]andnever[]